Kristian WindandClaude Opus 5
c2e2d66e76
Release / Build and publish image (push) Failing after 12m56s
The panel's watcher reported four 5xx today — twice from one address at 11:49, twice from another at 10:45 — and there is no way to find out what any of them were. verdande logs the real cause of every 500, but on a Rune the log belongs to the container and the container is replaced on every restart. So an operator is told that something broke and given nothing to act on, which is the worst of both: alarming and useless. Every 500 now writes a row: what the handler was attempting in its own words, the error it hit, the method and path, who was asking, and the request id that ties it back to the log line for whoever still has it. The "what" is the part a status code cannot give — "list projects" and "move task" are the difference between a fault you can find and one you can only count. Written best-effort and never checked. This is the path that is already reporting a failure, and a diagnostic that can itself fail the request would turn one broken screen into two. Threading the request through `internal()` and `storeError()` touched 108 call sites across 19 files, which is the price of not having had it there from the start. It is mechanical and the compiler checked all of it. Kept for thirty days by the nightly sweep: long enough to answer "what happened last week", short enough that a fault loop cannot fill the volume the tasks live on. Read at Indstillinger → Fejl, administrators only — it carries paths, account names and the server's own error strings. The empty state says "Ingen fejl registreret. Det er den rigtige tilstand", because a blank panel should not read as a broken one. The test drops a table and asks for the endpoint that reads it: the same code path a disk error takes, and the row that comes back has to name the operation, the account and the request. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
1.7 KiB
Go
48 lines
1.7 KiB
Go
package httpapi
|
|
|
|
import (
|
|
"net/http"
|
|
"time"
|
|
)
|
|
|
|
// What has gone wrong lately, kept where a restart cannot take it.
|
|
//
|
|
// The panel's watcher reports "HTTP 5xx, twice, at 11:49" — which is enough to
|
|
// know something broke and nothing at all to act on. The line that explains it is
|
|
// in the container's log, and a Rune's container is replaced on every restart, so
|
|
// by the time anybody looks the explanation is gone. These rows are the same
|
|
// information written somewhere that survives.
|
|
|
|
type serverErrorJSON struct {
|
|
ID string `json:"id"`
|
|
At string `json:"at"`
|
|
Method string `json:"method"`
|
|
Path string `json:"path"`
|
|
Status int `json:"status"`
|
|
// What the handler was doing, in its own words — "list projects", "move task".
|
|
What string `json:"what"`
|
|
Message string `json:"message"`
|
|
// Who was asking, when there was somebody: a fault only one account hits is a
|
|
// different problem from one everybody hits.
|
|
UserName string `json:"user_name,omitempty"`
|
|
// RequestID ties the row back to the log line, for whoever still has it.
|
|
RequestID string `json:"request_id,omitempty"`
|
|
}
|
|
|
|
func (s *Server) handleListErrors(w http.ResponseWriter, r *http.Request) {
|
|
errs, err := s.db.ListErrors(r.Context(), parseLimit(r.URL.Query().Get("limit"), 100, 500))
|
|
if err != nil {
|
|
s.internal(w, r, "list errors", err)
|
|
return
|
|
}
|
|
out := make([]serverErrorJSON, 0, len(errs))
|
|
for _, e := range errs {
|
|
out = append(out, serverErrorJSON{
|
|
ID: e.ID, At: e.At.Format(time.RFC3339), Method: e.Method, Path: e.Path,
|
|
Status: e.Status, What: e.What, Message: e.Message,
|
|
UserName: e.UserName, RequestID: e.RequestID,
|
|
})
|
|
}
|
|
writeJSON(w, http.StatusOK, map[string]any{"errors": out})
|
|
}
|