The three the handoff named as next. They are one commit because they are one mechanism: all three end in something being dragged, and a drop target cannot tell what is coming without the module they now share. Groups are foldable headings over the projects in the sidebar. A table rather than a `group_name` column on the project, because a group has to be renamable in one write, has to survive being emptied, and has to remember whether it is folded — none of which a string repeated on every project row can do. Folded state lives on the row, not in localStorage. The sidebar's *width* is a property of the screen you are sitting at, which is why that one is per browser; a folded group is a statement about the group — "this is the part of my work I am not in right now" — and it is true on the laptop and on the desktop. There is nobody else's answer to disagree with either: a group belongs to exactly one person. A shared project cannot be filed. `group_id` is a column on the project row, so a member grouping somebody else's project would move it in the owner's sidebar too — the same reason `sort_order` is owner-scoped. The listing reports the column only to the owner, so a viewer is never told where somebody else keeps it. Deleting a group takes the heading and leaves the projects, and the sidebar decides where a project renders by whether its group still exists rather than by the id alone. A group deleted in another tab arrives as one event and not one per project, so for a moment the projects still name a heading that is no longer drawn — filing by the raw id would drop them out of the sidebar entirely. Kommende gains the month grid the project pages already had, behind a Liste/Kalender toggle. The two views ask for different things — seven days from today against six whole weeks around an arbitrary month — so each loads its own, and the grid reports which dates it is showing rather than having the page guess. Which view is remembered in localStorage: a month of seven columns needs room, and the answer on a phone is not the answer on a wide monitor. And a task can now be dropped on a project in the sidebar, on a day in Kommende, or on a cell in any month grid. Onto a project it is a *move*, not a field: `sort_order` belongs to the project, so it has to find a place among that project's tasks and leave its old section behind. Each drag now carries its own MIME type. `getData` is deliberately unreadable while a drag is in the air — the browser hands the payload over on drop and not before, so a page cannot read what is being dragged across it — and `dataTransfer.types` is all a target has to decide with. Deciding is the point: calling preventDefault on a drag you cannot accept is what turns "no" into a silent, wrong drop. The sidebar takes a project and a task on the same row and has to tell them apart. Two things fell out of building it. The month grid has always had one cell narrower than the other six: `.today` styled the "I dag" button in the header, and the day cell for today wears the same class, so `margin-left: auto` was shrinking a grid item to its content. It is scoped to the header now. And a project page listed whatever was in the store rather than what belonged to that project, which did not matter until a task could leave a project while you were looking at it. Covered by eight new API tests and two new smoke tests, and the smoke tests drive the drags for real — the type check they exercise exists only while a drag is in flight, so nothing else can reach it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
146 lines
4.3 KiB
Go
146 lines
4.3 KiB
Go
package httpapi
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
"github.com/kristianwind/verdande/internal/store"
|
|
)
|
|
|
|
// Groups are the foldable headings over the projects in the sidebar.
|
|
//
|
|
// They sit outside /projects rather than under it: a group is not a project and
|
|
// has no members, no tasks and no roles. Every route here is scoped to the caller
|
|
// in the query itself, so there is no permission middleware to forget — a group
|
|
// that is not yours is not found.
|
|
|
|
type projectGroupJSON struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
Collapsed bool `json:"collapsed"`
|
|
SortOrder float64 `json:"sort_order"`
|
|
}
|
|
|
|
func toProjectGroupJSON(g store.ProjectGroup) projectGroupJSON {
|
|
return projectGroupJSON{ID: g.ID, Name: g.Name, Collapsed: g.Collapsed, SortOrder: g.SortOrder}
|
|
}
|
|
|
|
func (s *Server) handleListProjectGroups(w http.ResponseWriter, r *http.Request) {
|
|
groups, err := s.db.ListProjectGroups(r.Context(), userFrom(r.Context()).ID)
|
|
if err != nil {
|
|
s.internal(w, "list project groups", err)
|
|
return
|
|
}
|
|
out := make([]projectGroupJSON, 0, len(groups))
|
|
for _, g := range groups {
|
|
out = append(out, toProjectGroupJSON(g))
|
|
}
|
|
writeJSON(w, http.StatusOK, map[string]any{"groups": out})
|
|
}
|
|
|
|
type projectGroupRequest struct {
|
|
Name *string `json:"name"`
|
|
Collapsed *bool `json:"collapsed"`
|
|
}
|
|
|
|
func (s *Server) handleCreateProjectGroup(w http.ResponseWriter, r *http.Request) {
|
|
var req projectGroupRequest
|
|
if err := decodeJSON(w, r, &req); err != nil {
|
|
return
|
|
}
|
|
name := ""
|
|
if req.Name != nil {
|
|
name = strings.TrimSpace(*req.Name)
|
|
}
|
|
if fields := validateGroupName(name); len(fields) > 0 {
|
|
writeFieldErrors(w, fields)
|
|
return
|
|
}
|
|
|
|
g := &store.ProjectGroup{Name: name, OwnerID: userFrom(r.Context()).ID}
|
|
if req.Collapsed != nil {
|
|
g.Collapsed = *req.Collapsed
|
|
}
|
|
if err := s.db.CreateProjectGroup(r.Context(), g); err != nil {
|
|
s.internal(w, "create project group", err)
|
|
return
|
|
}
|
|
s.publishToOwner(r, "project_group.created", toProjectGroupJSON(*g))
|
|
writeJSON(w, http.StatusCreated, toProjectGroupJSON(*g))
|
|
}
|
|
|
|
func (s *Server) handleUpdateProjectGroup(w http.ResponseWriter, r *http.Request) {
|
|
var req projectGroupRequest
|
|
if err := decodeJSON(w, r, &req); err != nil {
|
|
return
|
|
}
|
|
groupID := chi.URLParam(r, "groupID")
|
|
userID := userFrom(r.Context()).ID
|
|
|
|
if req.Name != nil {
|
|
name := strings.TrimSpace(*req.Name)
|
|
if fields := validateGroupName(name); len(fields) > 0 {
|
|
writeFieldErrors(w, fields)
|
|
return
|
|
}
|
|
req.Name = &name
|
|
}
|
|
|
|
if err := s.db.UpdateProjectGroup(r.Context(), groupID, userID, store.ProjectGroupUpdate{
|
|
Name: req.Name, Collapsed: req.Collapsed,
|
|
}); err != nil {
|
|
s.storeError(w, "update project group", err)
|
|
return
|
|
}
|
|
g, err := s.db.GetProjectGroup(r.Context(), groupID, userID)
|
|
if err != nil {
|
|
s.storeError(w, "get project group", err)
|
|
return
|
|
}
|
|
s.publishToOwner(r, "project_group.updated", toProjectGroupJSON(*g))
|
|
writeJSON(w, http.StatusOK, toProjectGroupJSON(*g))
|
|
}
|
|
|
|
// handleDeleteProjectGroup removes the heading. The projects under it come back
|
|
// out as ungrouped, which is why this is not behind a confirmation about losing
|
|
// work: there is none to lose.
|
|
func (s *Server) handleDeleteProjectGroup(w http.ResponseWriter, r *http.Request) {
|
|
groupID := chi.URLParam(r, "groupID")
|
|
if err := s.db.DeleteProjectGroup(r.Context(), groupID, userFrom(r.Context()).ID); err != nil {
|
|
s.storeError(w, "delete project group", err)
|
|
return
|
|
}
|
|
s.publishToOwner(r, "project_group.deleted", map[string]string{"id": groupID})
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
// handleReorderProjectGroups takes the whole list, like the projects do — see
|
|
// handleReorderProjects for why.
|
|
func (s *Server) handleReorderProjectGroups(w http.ResponseWriter, r *http.Request) {
|
|
var req reorderProjectsRequest
|
|
if err := decodeJSON(w, r, &req); err != nil {
|
|
return
|
|
}
|
|
if len(req.IDs) > 500 {
|
|
writeFieldErrors(w, map[string]string{"ids": "at most 500 at a time"})
|
|
return
|
|
}
|
|
if err := s.db.ReorderProjectGroups(r.Context(), userFrom(r.Context()).ID, req.IDs); err != nil {
|
|
s.internal(w, "reorder project groups", err)
|
|
return
|
|
}
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
func validateGroupName(name string) map[string]string {
|
|
switch {
|
|
case name == "":
|
|
return map[string]string{"name": "required"}
|
|
case len([]rune(name)) > 200:
|
|
return map[string]string{"name": "must be 200 characters or fewer"}
|
|
}
|
|
return nil
|
|
}
|