verdande/internal/httpapi/auth_handlers.go

package httpapi

import (
	"errors"
	"net/http"
	"net/mail"
	"strings"
	"time"
	"unicode/utf8"

	"github.com/go-chi/chi/v5/middleware"

	"github.com/kristianwind/verdande/internal/auth"
	"github.com/kristianwind/verdande/internal/store"
)

// userJSON is what the API says about a person. It deliberately does not carry the
// password hash or the TOTP secret: those are not "fields that happen to be
// private", they are values that must not leave the process, and the way to
// guarantee that is for the response type not to have them.
type userJSON struct {
	ID          string `json:"id"`
	Email       string `json:"email"`
	Name        string `json:"name"`
	AvatarColor string `json:"avatar_color"`
	Timezone    string `json:"timezone"`
	Locale      string `json:"locale"`
	IsAdmin     bool   `json:"is_admin"`
	TOTPEnabled bool   `json:"totp_enabled"`
	// SidebarCollapsed is which sidebar headings this person has folded away. On
	// the account rather than in the browser, because folding one is a statement
	// about the work and not about the screen — the sidebar's width is the
	// opposite case and stays in localStorage.
	SidebarCollapsed []string `json:"sidebar_collapsed"`
	NavOrder         []string `json:"nav_order"`
	// DefaultReminderMin is the account's standing alarm on tasks that have a
	// clock, as minutes relative to the due moment and negative for before it.
	// Null is off, which is where every account starts.
	//
	// A pointer rather than a number with a sentinel, so that "off" and "at the
	// due moment" stay different answers: zero is a real setting here.
	DefaultReminderMin *int   `json:"default_reminder_min"`
	CreatedAt          string `json:"created_at"`
}

func toUserJSON(u *store.User) userJSON {
	collapsed := u.SidebarCollapsed
	// Never null in the response: a client that has to check for both an absent
	// array and an empty one will one day check for only one of them.
	if collapsed == nil {
		collapsed = []string{}
	}
	order := u.NavOrder
	if order == nil {
		order = []string{}
	}
	return userJSON{
		ID: u.ID, Email: u.Email, Name: u.Name, AvatarColor: u.AvatarColor,
		Timezone: u.Timezone, Locale: u.Locale, IsAdmin: u.IsAdmin,
		TOTPEnabled: u.TOTPEnabled, SidebarCollapsed: collapsed, NavOrder: order,
		DefaultReminderMin: u.DefaultReminderMin,
		CreatedAt:          u.CreatedAt.Format(time.RFC3339),
	}
}

// handleSetSidebarSections records which sidebar headings are folded away.
//
// Its own route rather than a field on the profile: that one backs a form with a
// save button and validates three fields together, and this writes on every click
// of a chevron. Sharing the path would mean a fold sending a name and a timezone
// it was never asked to change — and a validation error on one of those failing a
// fold.
//
// The keys are the sidebar's and are not checked here. An unknown one costs
// nothing: the sidebar folds the headings it recognises and ignores the rest, so
// a heading that is renamed or removed leaves a harmless entry rather than a
// migration.
func (s *Server) handleSetSidebarSections(w http.ResponseWriter, r *http.Request) {
	var req struct {
		Sections []string `json:"sections"`
	}
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	// A cap, because this is a list the client decides the length of. Twenty is far
	// more headings than the sidebar has ever had.
	if len(req.Sections) > 20 {
		writeError(w, http.StatusBadRequest, CodeBadRequest, "too many sections")
		return
	}
	user := userFrom(r.Context())
	if err := s.db.SetSidebarCollapsed(r.Context(), user.ID, req.Sections); err != nil {
		s.storeError(w, r, "set sidebar sections", err)
		return
	}
	w.WriteHeader(http.StatusNoContent)
}

// handleSetNavOrder records the order of the fixed views in the sidebar.
//
// Its own route for the same reason as the folds: this writes on every drop, and
// sharing the profile's path would make a reorder send a name and a timezone it
// was never asked to change.
func (s *Server) handleSetNavOrder(w http.ResponseWriter, r *http.Request) {
	var req struct {
		Order []string `json:"order"`
	}
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	if len(req.Order) > 20 {
		writeError(w, http.StatusBadRequest, CodeBadRequest, "too many entries")
		return
	}
	user := userFrom(r.Context())
	if err := s.db.SetNavOrder(r.Context(), user.ID, req.Order); err != nil {
		s.storeError(w, r, "set nav order", err)
		return
	}
	w.WriteHeader(http.StatusNoContent)
}

// handleSetDefaultReminder turns the account's standing alarm on or off.
//
// `minutes` is relative to the due moment and negative for before it, which is the
// convention reminders.offset_min uses because that is the column it lands in. Null
// is off. A positive number is refused: an alarm AFTER the thing it is warning
// about is not a reminder, and allowing it here would make the one mistake this
// value can make — a sign the wrong way round — look like a choice.
func (s *Server) handleSetDefaultReminder(w http.ResponseWriter, r *http.Request) {
	var req struct {
		Minutes *int `json:"minutes"`
	}
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	if req.Minutes != nil {
		switch {
		case *req.Minutes > 0:
			writeFieldErrors(w, map[string]string{"minutes": "must be zero or negative — an alarm comes before"})
			return
		// A week is the outer edge of "remind me ahead of this"; beyond it the
		// number is far more likely to be a unit mistake than an intention.
		case *req.Minutes < -7*24*60:
			writeFieldErrors(w, map[string]string{"minutes": "must be within a week of the due time"})
			return
		}
	}
	user := userFrom(r.Context())
	if err := s.db.SetDefaultReminder(r.Context(), user.ID, req.Minutes); err != nil {
		s.storeError(w, r, "set default reminder", err)
		return
	}
	w.WriteHeader(http.StatusNoContent)
}

// --- sign in -----------------------------------------------------------------

type loginRequest struct {
	Email    string `json:"email"`
	Password string `json:"password"`
}

type loginResponse struct {
	User         *userJSON `json:"user,omitempty"`
	TOTPRequired bool      `json:"totp_required"`
}

func (s *Server) handleLogin(w http.ResponseWriter, r *http.Request) {
	var req loginRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}

	user, err := s.db.UserByEmail(r.Context(), req.Email)
	if err != nil || auth.VerifyPassword(user.PasswordHash, req.Password) != nil {
		// One message for "no such account" and for "wrong password". Telling them
		// apart turns the login form into a way to enumerate who has an account
		// here, which for a private instance is most of what an attacker wants.
		//
		// The timing still differs — a missing user skips the Argon2 work — and
		// closing that would mean hashing against a dummy on every miss. Not done:
		// it costs 19 MiB per probe and hands over an easy way to exhaust memory.
		writeError(w, http.StatusUnauthorized, CodeUnauthorized,
			"that email address and password do not match an account")
		return
	}

	// Argon2 parameters get raised over time; a login is the only moment the
	// plaintext exists and an upgrade is possible.
	if auth.NeedsRehash(user.PasswordHash) {
		if hash, err := auth.HashPassword(req.Password); err == nil {
			if err := s.db.UpdatePasswordHash(r.Context(), user.ID, hash, ""); err != nil {
				s.log.Warn("rehash password", "err", err, "user", user.ID)
			}
		}
	}

	// The bucket is cleared only when the login is *finished*.
	//
	// It used to be cleared here, on the strength of the password alone — before
	// the second factor had been asked for at all. That handed somebody who
	// already had the password an unlimited supply of ten-guess batches: log in,
	// get a fresh bucket and a fresh pending session, spend ten guesses on the
	// code, log in again. At three valid codes in any moment and twenty requests a
	// second, that is even odds inside an afternoon — against the one control that
	// exists precisely for when the password is already gone.
	//
	// So an account with a second factor clears nothing yet. handleLoginTOTP does
	// it, once the code is right.
	if !user.TOTPEnabled {
		s.loginLimiter.reset(clientIP(r))
	}

	// A session that still needs a code gets a short life of its own: long enough
	// to fetch a phone, not long enough to be worth stealing.
	ttl := s.cfg.SessionTTL
	if user.TOTPEnabled {
		ttl = 10 * time.Minute
	}
	token, _, err := s.db.CreateSession(r.Context(), user.ID, r.UserAgent(), clientIP(r), ttl, user.TOTPEnabled)
	if err != nil {
		s.internal(w, r, "create session", err)
		return
	}
	s.setSessionCookie(w, token, ttl)

	if user.TOTPEnabled {
		writeJSON(w, http.StatusOK, loginResponse{TOTPRequired: true})
		return
	}
	uj := toUserJSON(user)
	writeJSON(w, http.StatusOK, loginResponse{User: &uj})
}

type totpRequest struct {
	Code string `json:"code"`
}

// handleLoginTOTP completes a two-step login. It runs behind requirePendingSession,
// so it is reachable only by a session that has already passed the password step.
func (s *Server) handleLoginTOTP(w http.ResponseWriter, r *http.Request) {
	var req totpRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	user := userFrom(r.Context())
	session := sessionFrom(r.Context())

	// Counted per account as well as per address.
	//
	// The address bucket alone is defeated by anybody with more than one, which is
	// the ordinary case — a phone and a laptop is already two. A code is six
	// digits: the only thing that makes it safe is that guesses are scarce, and
	// scarcity has to be counted against the thing being attacked.
	if ok, retry := s.totpLimiter.allow(user.ID); !ok {
		w.Header().Set("Retry-After", retryAfterSeconds(retry))
		writeError(w, http.StatusTooManyRequests, CodeRateLimited,
			"too many verification codes; wait a moment and try again")
		return
	}

	step, err := auth.TOTPStep(user.TOTPSecret, req.Code, time.Now())
	if err == nil {
		// The code is right; now it must also be unused. A TOTP code stays valid for
		// its whole window, so one observed in flight — a phishing page, a proxy,
		// over the shoulder — could otherwise be replayed until it expires. Spending
		// the step here makes it single-use: a second presentation of the same code,
		// or an earlier one, finds the step already gone.
		fresh, cerr := s.db.ConsumeTOTPStep(r.Context(), user.ID, step)
		if cerr != nil {
			s.internal(w, r, "consume totp step", cerr)
			return
		}
		if !fresh {
			writeError(w, http.StatusUnauthorized, CodeUnauthorized,
				"that verification code has already been used")
			return
		}
	}
	if err != nil {
		// A recovery code is accepted in the same field. Making somebody find a
		// different form while locked out of their account is a poor time to
		// introduce a second concept.
		used, rerr := s.db.UseRecoveryCode(r.Context(), user.ID, req.Code)
		if rerr != nil || !used {
			// The pending session is left alive on purpose.
			//
			// Ending it on the first wrong digit was considered and rejected: it
			// would make somebody who mistyped one number type their password again,
			// and it buys almost nothing. What makes a six-digit code safe is that
			// guesses are scarce, and the per-account bucket above is what makes
			// them scarce — ten an hour, however many times the password is
			// re-entered. The attack this closes was never "one session, many
			// guesses"; it was "a fresh bucket for every password check".
			writeError(w, http.StatusUnauthorized, CodeUnauthorized,
				"that verification code is not valid")
			return
		}
		s.log.Info("recovery code used", "user", user.ID)
	}

	// Finished. Now the buckets may be cleared — both of them, so somebody who
	// fumbled the code twice is not still waiting once they get it right.
	s.loginLimiter.reset(clientIP(r))
	s.totpLimiter.reset(user.ID)

	if err := s.db.PromoteSession(r.Context(), session.ID, s.cfg.SessionTTL); err != nil {
		s.internal(w, r, "promote session", err)
		return
	}
	// The cookie is reissued so its lifetime matches the session's new one.
	if cookie, cerr := r.Cookie(s.cookieName()); cerr == nil {
		s.setSessionCookie(w, cookie.Value, s.cfg.SessionTTL)
	}

	uj := toUserJSON(user)
	writeJSON(w, http.StatusOK, loginResponse{User: &uj})
}

func (s *Server) handleLogout(w http.ResponseWriter, r *http.Request) {
	if session := sessionFrom(r.Context()); session != nil {
		if err := s.db.DeleteSession(r.Context(), session.ID); err != nil {
			s.log.Warn("delete session", "err", err)
		}
	}
	s.clearSessionCookie(w)
	w.WriteHeader(http.StatusNoContent)
}

func (s *Server) handleMe(w http.ResponseWriter, r *http.Request) {
	writeJSON(w, http.StatusOK, toUserJSON(userFrom(r.Context())))
}

type updateProfileRequest struct {
	Name     *string `json:"name"`
	Timezone *string `json:"timezone"`
	Locale   *string `json:"locale"`
}

// handleUpdateProfile changes name, timezone and language.
//
// The timezone is not cosmetic: every date in the app is resolved in it, so "i
// morgen kl 9" means a different instant after this call than before. Which is
// exactly why it has to be changeable — an account created from an invite
// inherits a default, and somebody in another country would otherwise have every
// due date land an hour out with no way to say so.
func (s *Server) handleUpdateProfile(w http.ResponseWriter, r *http.Request) {
	var req updateProfileRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	user := userFrom(r.Context())

	name, timezone, locale := user.Name, user.Timezone, user.Locale
	fields := map[string]string{}

	if req.Name != nil {
		name = strings.TrimSpace(*req.Name)
		if name == "" {
			fields["name"] = "required"
		} else if utf8.RuneCountInString(name) > 80 {
			fields["name"] = "must be at most 80 characters"
		}
	}
	if req.Timezone != nil {
		timezone = strings.TrimSpace(*req.Timezone)
		// Checked against the running system's zone database rather than a list
		// kept here: a hardcoded list goes stale every time a country moves its
		// clocks, and this one is the same database the dates are resolved with.
		if _, err := time.LoadLocation(timezone); err != nil || timezone == "" {
			fields["timezone"] = "must be a zone like Europe/Copenhagen"
		}
	}
	if req.Locale != nil {
		locale = strings.TrimSpace(*req.Locale)
		// The locale picks which quick-add grammar parses a line, so an unknown
		// one would quietly stop "i morgen" being understood.
		if locale != "da" && locale != "en" {
			fields["locale"] = "must be da or en"
		}
	}
	if len(fields) > 0 {
		writeFieldErrors(w, fields)
		return
	}

	if err := s.db.UpdateProfile(r.Context(), user.ID, name, timezone, locale); err != nil {
		s.storeError(w, r, "update profile", err)
		return
	}

	updated, err := s.db.UserByID(r.Context(), user.ID)
	if err != nil {
		s.internal(w, r, "reload user", err)
		return
	}
	writeJSON(w, http.StatusOK, toUserJSON(updated))
}

// --- creating accounts --------------------------------------------------------

type signupRequest struct {
	Token    string `json:"token"`
	Name     string `json:"name"`
	Password string `json:"password"`
	Timezone string `json:"timezone,omitempty"`
	Locale   string `json:"locale,omitempty"`
}

// handleSignup creates an account from an invite. There is no open registration:
// the email address comes from the invite, not from the form, so an invite cannot
// be redirected to somebody else.
func (s *Server) handleSignup(w http.ResponseWriter, r *http.Request) {
	var req signupRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}

	invite, err := s.db.InviteByToken(r.Context(), req.Token)
	if err != nil {
		writeError(w, http.StatusBadRequest, CodeBadRequest,
			"this invite link is not valid or has expired")
		return
	}

	fields := map[string]string{}
	name := strings.TrimSpace(req.Name)
	if name == "" {
		fields["name"] = "required"
	}
	if msg := checkPassword(req.Password); msg != "" {
		fields["password"] = msg
	}
	if len(fields) > 0 {
		writeFieldErrors(w, fields)
		return
	}

	hash, err := auth.HashPassword(req.Password)
	if err != nil {
		s.internal(w, r, "hash password", err)
		return
	}

	user := &store.User{
		Email: invite.Email, Name: name, PasswordHash: hash,
		Timezone: req.Timezone, Locale: req.Locale,
	}
	if err := s.db.CreateUser(r.Context(), user, inboxName(req.Locale)); err != nil {
		if errors.Is(err, store.ErrEmailInUse) {
			writeError(w, http.StatusConflict, CodeConflict,
				"an account already exists for that email address")
			return
		}
		s.internal(w, r, "create user", err)
		return
	}

	// Accepting the invite is what adds the membership and burns the token, in one
	// transaction: a signup that half-succeeded would leave a usable invite behind.
	if err := s.db.AcceptInvite(r.Context(), invite.ID, user.ID); err != nil {
		s.internal(w, r, "accept invite", err)
		return
	}

	s.startSession(w, r, user)
}

type bootstrapRequest struct {
	Email    string `json:"email"`
	Name     string `json:"name"`
	Password string `json:"password"`
	Timezone string `json:"timezone,omitempty"`
	Locale   string `json:"locale,omitempty"`
}

// handleBootstrap creates the first administrator, and only ever the first: the
// endpoint refuses once any account exists. That is what makes it safe to leave
// unauthenticated — it has to be, because there is nobody to authenticate as yet.
//
// The race matters. Two requests arriving together must not both see an empty
// database, so the check and the insert happen in one transaction inside the store.
func (s *Server) handleBootstrap(w http.ResponseWriter, r *http.Request) {
	var req bootstrapRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}

	fields := map[string]string{}
	if _, err := mail.ParseAddress(req.Email); err != nil {
		fields["email"] = "must be an email address"
	}
	if strings.TrimSpace(req.Name) == "" {
		fields["name"] = "required"
	}
	if msg := checkPassword(req.Password); msg != "" {
		fields["password"] = msg
	}
	if len(fields) > 0 {
		writeFieldErrors(w, fields)
		return
	}

	hash, err := auth.HashPassword(req.Password)
	if err != nil {
		s.internal(w, r, "hash password", err)
		return
	}

	user := &store.User{
		Email: req.Email, Name: strings.TrimSpace(req.Name), PasswordHash: hash,
		IsAdmin: true, Timezone: req.Timezone, Locale: req.Locale,
	}
	if err := s.db.CreateFirstAdmin(r.Context(), user, inboxName(req.Locale)); err != nil {
		if errors.Is(err, store.ErrAlreadySetUp) {
			writeError(w, http.StatusConflict, CodeConflict, "this instance is already set up")
			return
		}
		s.internal(w, r, "create first admin", err)
		return
	}

	s.log.Info("first administrator created", "user", user.ID, "email", user.Email)
	s.startSession(w, r, user)
}

// handleSetupState tells the sign-in page whether to offer setup or a login form.
// It reveals only whether any account exists, which anyone can determine anyway by
// looking at whether the setup form works.
func (s *Server) handleSetupState(w http.ResponseWriter, r *http.Request) {
	n, err := s.db.UserCount(r.Context())
	if err != nil {
		s.internal(w, r, "count users", err)
		return
	}
	// Udgaven hører til her og ikke på /auth/me: den er en egenskab ved
	// instansen, ikke ved den, der er logget ind, og fladen skal kende den, før
	// nogen er. Det her er i forvejen kaldet, der spørger "hvad er det her for en
	// instans", så den følger med uden en ekstra tur.
	writeJSON(w, http.StatusOK, struct {
		NeedsSetup bool   `json:"needs_setup"`
		Edition    string `json:"edition"`
	}{n == 0, s.edition()})
}

func (s *Server) startSession(w http.ResponseWriter, r *http.Request, user *store.User) {
	token, _, err := s.db.CreateSession(r.Context(), user.ID, r.UserAgent(), clientIP(r), s.cfg.SessionTTL, false)
	if err != nil {
		s.internal(w, r, "create session", err)
		return
	}
	s.setSessionCookie(w, token, s.cfg.SessionTTL)
	uj := toUserJSON(user)
	writeJSON(w, http.StatusCreated, loginResponse{User: &uj})
}

// --- password reset -----------------------------------------------------------

type forgotRequest struct {
	Email string `json:"email"`
}

// handleForgotPassword always answers the same way.
//
// Saying "no account with that address" would turn this into an account-existence
// oracle that needs no password at all. The cost is that somebody who mistypes
// their address waits for an email that never comes, which is the better failure.
func (s *Server) handleForgotPassword(w http.ResponseWriter, r *http.Request) {
	var req forgotRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}

	user, err := s.db.UserByEmail(r.Context(), req.Email)
	if err == nil {
		token, err := s.db.CreatePasswordReset(r.Context(), user.ID, s.cfg.ResetTTL)
		if err != nil {
			s.internal(w, r, "create password reset", err)
			return
		}
		link := s.cfg.BaseURL + "/reset?token=" + token
		if err := s.mail.SendPasswordReset(r.Context(), user.Email, user.Name, link, s.cfg.ResetTTL); err != nil {
			s.log.Error("send password reset", "err", err, "user", user.ID)
		}
	}

	writeJSON(w, http.StatusOK, map[string]string{
		"status": "if that address has an account, a reset link is on its way",
	})
}

type resetRequest struct {
	Token    string `json:"token"`
	Password string `json:"password"`
}

func (s *Server) handleResetPassword(w http.ResponseWriter, r *http.Request) {
	var req resetRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	if msg := checkPassword(req.Password); msg != "" {
		writeFieldErrors(w, map[string]string{"password": msg})
		return
	}

	userID, err := s.db.UsePasswordReset(r.Context(), req.Token)
	if err != nil {
		writeError(w, http.StatusBadRequest, CodeBadRequest,
			"this reset link is not valid or has expired")
		return
	}

	hash, err := auth.HashPassword(req.Password)
	if err != nil {
		s.internal(w, r, "hash password", err)
		return
	}
	// Every session ends: a password reset is what somebody does when they think
	// another person has been in their account.
	if err := s.db.UpdatePasswordHash(r.Context(), userID, hash, ""); err != nil {
		s.internal(w, r, "update password", err)
		return
	}

	w.WriteHeader(http.StatusNoContent)
}

type changePasswordRequest struct {
	CurrentPassword string `json:"current_password"`
	NewPassword     string `json:"new_password"`
}

func (s *Server) handleChangePassword(w http.ResponseWriter, r *http.Request) {
	var req changePasswordRequest
	if err := decodeJSON(w, r, &req); err != nil {
		return
	}
	user := userFrom(r.Context())

	// The current password is required even though the caller is signed in: it is
	// what stops an unattended laptop from becoming a permanent account takeover.
	if err := auth.VerifyPassword(user.PasswordHash, req.CurrentPassword); err != nil {
		writeFieldErrors(w, map[string]string{"current_password": "not correct"})
		return
	}
	if msg := checkPassword(req.NewPassword); msg != "" {
		writeFieldErrors(w, map[string]string{"new_password": msg})
		return
	}

	hash, err := auth.HashPassword(req.NewPassword)
	if err != nil {
		s.internal(w, r, "hash password", err)
		return
	}
	keep := ""
	if session := sessionFrom(r.Context()); session != nil {
		keep = session.ID
	}
	if err := s.db.UpdatePasswordHash(r.Context(), user.ID, hash, keep); err != nil {
		s.internal(w, r, "update password", err)
		return
	}
	w.WriteHeader(http.StatusNoContent)
}

// --- validation ---------------------------------------------------------------

// Password rules, and only these.
//
// A length floor and nothing else is deliberate. Composition rules — a digit, a
// symbol, a capital — measurably push people towards "Password1!" and are no longer
// recommended by NIST or OWASP. Length is what actually helps, and a passphrase
// must not be rejected for lacking punctuation.
const (
	minPasswordLength = 10
	maxPasswordLength = 1024 // Argon2 will hash anything; this bounds the work
)

func checkPassword(p string) string {
	switch {
	case p == "":
		return "required"
	case utf8.RuneCountInString(p) < minPasswordLength:
		return "must be at least 10 characters"
	case len(p) > maxPasswordLength:
		return "is too long"
	}
	return ""
}

// inboxName is the one string that has to be right at account creation, before the
// user has ever seen a settings page to state a preference on.
func inboxName(locale string) string {
	if strings.HasPrefix(strings.ToLower(locale), "en") {
		return "Inbox"
	}
	return "Indbakke"
}

// internal logs the real error and tells the client nothing about it. The detail
// belongs in the log, where the operator can see it; in the response it would be a
// description of the server's internals handed to whoever asked.
//
// It is also written to the database. On a Rune the log is the container's, and
// every restart begins a new one — so the panel reports "HTTP 5xx, twice, at
// 11:49" long after the line explaining it has gone, which tells an operator that
// something broke and gives them no way to find out what. The row outlives the
// container; Indstillinger → Fejl is where it is read.
// upstream reports a failure that came from somebody else's service.
//
// Separate from `internal` because the cause is different and so is the fix: a 500
// is this server broken, and this is Google — or whoever — saying no. The status
// says so (502), and the message is passed through rather than replaced, because
// "invalid_grant" or "insufficient authentication scopes" is the whole diagnosis
// and a generic sentence in its place throws it away.
//
// It is recorded like a 500 for exactly the reason the error log exists: a Gmail
// sync that has been failing for a week is invisible otherwise. The background job
// writes a log line the next restart erases, and nobody is watching the one screen
// that would have said so.
// StatusUpstreamRefused is what this server answers when a service it depends on
// says no. Not 502, though that is what it means: a proxy is entitled to replace
// the body of an origin 5xx with a page of its own, and Cloudflare does. That
// swallowed every explanation this server produced — "gmail: 403 Forbidden",
// "the panel refused: HTTP 401" — and left the interface with nothing to show but
// "something went wrong". A 4xx passes through untouched, and the truth reaching
// the person who has to act on it beats the tidier status code.
const StatusUpstreamRefused = http.StatusUnprocessableEntity

func (s *Server) upstream(w http.ResponseWriter, r *http.Request, code, what string, err error) {
	s.log.Warn(what, "err", err)

	userID := ""
	if u := userFrom(r.Context()); u != nil {
		userID = u.ID
	}
	s.db.RecordError(r.Context(), store.ServerError{
		Method: r.Method, Path: r.URL.Path, Status: StatusUpstreamRefused,
		What: what, Message: err.Error(), UserID: userID,
		RequestID: middleware.GetReqID(r.Context()),
	})

	writeError(w, StatusUpstreamRefused, code, err.Error())
}

func (s *Server) internal(w http.ResponseWriter, r *http.Request, what string, err error) {
	s.log.Error(what, "err", err)

	userID := ""
	if u := userFrom(r.Context()); u != nil {
		userID = u.ID
	}
	// Best effort, and deliberately not checked: this is the path that is already
	// reporting a failure, and a diagnostic that can fail the request would turn
	// one broken screen into two.
	s.db.RecordError(r.Context(), store.ServerError{
		Method: r.Method, Path: r.URL.Path, Status: http.StatusInternalServerError,
		What: what, Message: err.Error(), UserID: userID,
		RequestID: middleware.GetReqID(r.Context()),
	})

	writeError(w, http.StatusInternalServerError, CodeInternal, "something went wrong")
}