fix(forms): Safari focused none of them, and a board could not make a section
Two reports, one sentence between them: "sections have no function, because you cannot create more than one." `autofocus` does not work in Safari for anything inserted after the page has loaded, and every inline form here is inserted after the page has loaded — rename a project, add a section, name a group. In Safari they all opened with no cursor in them and what you typed went nowhere. That does not look like a bug. It looks like the feature does not work. `use:focusOnMount` replaces all seventeen. And the board had no way to add a section at all. The button lived only in the list view, which is the one place nobody looks for it: a column on a board *is* a section, so that is where you go to make one. Chasing this turned up a third. The task drawer's three fields save on blur, and closing the drawer *is* a blur — the input is being unmounted and the browser fires blur on the way out. If the task left the store in the same moment, `task` was already null and the handler threw `Cannot read properties of null`, stopping the page. It only became reproducible once focus actually worked. Fields are 16px on a touch device now, whatever the component asked for. Below 16px, iOS Safari zooms in when a field takes focus and does not zoom back out — so the whole interface is left too large and has to be pinched back by hand, once per field. The type scale tops out at 15px, so every input in the app did it. The sidebar's resize handle sat at `right: -3px`. An absolutely positioned child counts towards its container's scrollable overflow, and `overflow-y: auto` resolves the other axis to `auto` too — so those three pixels gave the whole menu a horizontal scrollbar on every desktop, always. The account name could do it as well: `overflow: hidden` with no `min-width: 0` cannot shrink, so the row grew instead of ellipsing. There is a WebKit pass in the suite now, over one test. The rest stays Chromium on purpose — a smoke test exists to catch a build that does not work, and three engines find the same bug three times — but focus is the exception, and it took a person using the app to find that out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
1da7ea64bf
commit
eaff890860
@@ -12,6 +12,7 @@
|
||||
*/
|
||||
import { api, humanMessage } from '$lib/api.js';
|
||||
import { app } from '$lib/stores.svelte.js';
|
||||
import { focusOnMount } from '$lib/focus.js';
|
||||
|
||||
let { task, onclose } = $props();
|
||||
|
||||
@@ -96,8 +97,21 @@
|
||||
.catch(() => {});
|
||||
});
|
||||
|
||||
/** Sends a patch through the store, so the row behind the drawer updates too. */
|
||||
/**
|
||||
* Sends a patch through the store, so the row behind the drawer updates too.
|
||||
*
|
||||
* `task` can be null by the time this runs. The three fields below save on
|
||||
* blur, and closing the drawer *is* a blur — the input is being unmounted, and
|
||||
* the browser fires blur on the way out. If the task left `app.tasks` in the
|
||||
* same moment (it was completed, it was moved, another browser deleted it),
|
||||
* `app.detailTask` is already null and this is a handler for a task that is no
|
||||
* longer there.
|
||||
*
|
||||
* It threw `Cannot read properties of null` and stopped the page. Nothing to
|
||||
* save is not an error; it is the ordinary end of an edit nobody made.
|
||||
*/
|
||||
async function save(patch) {
|
||||
if (!task) return;
|
||||
await app.update(task.id, patch);
|
||||
}
|
||||
|
||||
@@ -114,6 +128,7 @@
|
||||
* worse than one that does nothing.
|
||||
*/
|
||||
async function saveContent() {
|
||||
if (!task) return;
|
||||
const trimmed = content.trim();
|
||||
if (!trimmed || trimmed === task.content) {
|
||||
content = task.content;
|
||||
@@ -181,11 +196,12 @@
|
||||
}
|
||||
|
||||
function saveDescription() {
|
||||
if (description === (task.description ?? '')) return;
|
||||
if (!task || description === (task.description ?? '')) return;
|
||||
save({ description });
|
||||
}
|
||||
|
||||
function saveLabels() {
|
||||
if (!task) return;
|
||||
const list = labels
|
||||
.split(',')
|
||||
.map((l) => l.trim())
|
||||
@@ -358,9 +374,9 @@
|
||||
|
||||
<div class="scroll">
|
||||
<div class="field">
|
||||
<!-- svelte-ignore a11y_autofocus -->
|
||||
<input
|
||||
class="title"
|
||||
use:focusOnMount
|
||||
bind:value={content}
|
||||
onblur={saveContent}
|
||||
aria-label="Opgavens tekst"
|
||||
|
||||
Reference in New Issue
Block a user