kristianwindandClaude Opus 5
dccb87d15e
Five files under docs/, the names the family agreed: README, SETUP,
ARCHITECTURE, CONTRACT, RELEASE. Plus ci/check-docs.php, ported from
woo-security-manager 52dd99d, wired into the static job.
CONTRACT.md is generated from the source rather than written from memory, and
that was the right instruction: my first sweep read only single-quoted hook
names and missed two rows, one of them update_plugins_{$hostname} — the hook
behind the live-shop collision, written with interpolation and therefore
invisible to a pattern built from the concept of the line. Nine hooks
documented: six wc_edm_* filters this plugin offers, three wpmgr_* it both
offers and answers through its copy of the frozen shared-menu.php.
Two hooks the checker structurally cannot see are listed by hand with a note
saying so: wc_edm_prune_audit_log (add_action on a class constant) and
update_plugins_{$hostname} (interpolated). A generated list beats a remembered
one and is still a list of what the generator can see.
The checker needed two fixes before it was safe to run here.
🔴 The published version reads HOOK_PREFIX from ci/plugin.conf for the
documented side, and refuses without it — then tests the source side against a
hardcoded 'nlsec_'. Ported verbatim that is not a green over nothing, which
would be easy to spot. Measured in this tree with CONTRACT.md documenting no
hook at all:
3 hook(s) in the shipped source and not in docs/CONTRACT.md:
wpmgr_dashboard_cards, wpmgr_menu_glyph, wpmgr_menu_title
Red, specific, and blind to all six wc_edm_* hooks — because 'wpmgr_' is the
same string in every tree and 'nlsec_' is the one that is not. Fix those three
and it goes green over six undocumented contract hooks, with a red run behind
you as evidence that it works. A partially blind check that fails is more
convincing than one that passes.
Note which step disarmed the guard. The floor at 20 shipped PHP files refused
to run in this 14-file tree, and that refusal was the only thing standing in
the way; the porting instructions were to add HOOK_PREFIX and adjust the floor.
Doing as told is what removed the protection — two wrongs cancelling into a
pass, in the order CLAUDE.md predicts, because the floor is the error you can
see and the prefix is not.
Both numbers now come from the conf (HOOK_PREFIX, MIN_SHIPPED_PHP_FILES) and
both refuse rather than defaulting. The inherited literal 20 is gone: a second
hardcoded number per plugin is a second thing to re-measure on every port.
Ten selftest assertions, 58 total. Four failure modes, the two refusals, the
counts on the pass, and the row that matters most:
🔴 A hook name in a COMMENT must not read as a hook call. CONTRACT.md documents
a filter by showing the apply_filters() a consumer makes, and the same example
sits in a docblock — so a checker that reads comments reports this plugin
consuming a filter it answers, in the file explaining why it must not. That
assertion is a control asserting a PASS, which is the kind that can quietly
become unable to fail, so it names the specific success line rather than
reading an exit code, and it is proven both ways: with token_get_all's
T_COMMENT branch made inert, exactly one of 58 assertions fails and it is that
one.
docs/TESTING-AND-RELEASES.md is folded into RELEASE.md and deleted rather than
left beside it — two copies of a rule is how the copies start to disagree.
Folding surfaced that it still documented the pre-rename Update URI
(kw/woocommerce-email-discount-manager) and still recommended, as future work,
the split into a releases-only repository that has already happened. Both
corrected in place, with the correction dated.
docs/ is not in ci/dist-files.sh — measured, 0 docs files in the zip.
static=0 selftest=0 site=0; site still 69 assertions on WordPress 7.1.2 with
WooCommerce 11.1.2. ci/ and docs/ ship nothing, so no version bump.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
=== Nolimit Discounts === Contributors: kristianwind Tags: woocommerce, discount, email, shipping, coupon Requires at least: 5.8 Tested up to: 7.1.2 Requires PHP: 7.4 Stable tag: 1.6.3 WC requires at least: 6.0 WC tested up to: 11.1.2 License: GPLv2 or later License URI: https://www.gnu.org/licenses/gpl-2.0.html Apply discounts and show/hide shipping methods based on the customer's email address. == Description == Nolimit Discounts lets you give discounts and filter available shipping methods based on the email address a customer logs in or checks out with. = Discount Groups = * Create discount groups with a name and a discount percent. * Attach any number of WooCommerce product categories to a group (drag & drop ordering). * The group's discount percent applies to all products in the attached categories. = Email Assignments = Assign an email pattern to exactly one of three discount types: * **Group** — the customer inherits a discount group's percent and categories. * **Coupon** — an existing WooCommerce coupon is auto-applied at checkout. * **Custom** — a custom percent applied to the entire cart. Email patterns can be: * A full email address: `john@example.com` * A domain: `@company.com` (matches everyone on that domain) * A partial match: `john` (matches any email containing "john") Matching priority: exact email first, then domain, then partial match. Assignments can be toggled active/inactive and work for both logged-in users and guests (via the checkout billing email field, tracked with AJAX). Every assignment can additionally grant **free shipping** — all shipping methods become free at checkout for matching emails, regardless of the assignment type. Coupon assignments pick from your existing WooCommerce coupons in a dropdown. = Shipping Rules = * Per discount group, choose which shipping methods are shown or hidden. * No rules for a group means all shipping methods behave normally. * If any method is set to "Show", only "Show" methods are offered (whitelist). * Drag & drop reordering controls the order methods appear in at checkout. = How discounts are applied = * Group and custom discounts are applied as negative fees on the cart. * Coupons are applied via the standard WooCommerce coupon system. == Installation == 1. Upload the `woocommerce-email-discount-manager` folder to `/wp-content/plugins/`. 2. Make sure WooCommerce is installed and active. 3. Activate the plugin through the Plugins screen in WordPress. 4. Go to Nolimit → Discounts to configure groups, assignments and shipping rules. = REST API = The plugin exposes a `wc-edm/v1` namespace for remote management (groups, email assignments, shipping rules, audit log). Every route requires an authenticated user with the `manage_woocommerce` capability — use a WordPress Application Password over HTTPS. Requests are rate limited per user (or per IP when unauthenticated) and all changes are written to the audit log. Both are adjustable with filters: * `wc_edm_rate_limit_enabled` (bool) * `wc_edm_rate_limit_max_requests` (int, $method) * `wc_edm_rate_limit_window` (int seconds, $method) * `wc_edm_audit_log_enabled` (bool) * `wc_edm_audit_log_retention_days` (int) * `wc_edm_client_ip` (string) — override IP resolution behind a proxy/CDN == Frequently Asked Questions == = Does it work for guests? = Yes. When a guest types their email in the checkout billing email field, the plugin stores it in the WooCommerce session via AJAX and recalculates the cart, so discounts and shipping rules apply immediately. = What happens if several patterns match one email? = The most specific match wins: exact email, then domain, then partial match. == Changelog == = 1.6.3 = * The WooCommerce version this plugin declares as tested is now the same in both places it is written. The readme still said 11.1.0 while the plugin itself said 11.1.2. = 1.6.2 = * Declares compatibility with WordPress 7.1.2 and WooCommerce 11.1.2, both tested. No functional change. = 1.6.1 = * The status label on the Nolimit dashboard card is now readable. It was white text on a light overlay, which on this plugin's green gave 3.5:1 where 4.5:1 is the accessibility minimum. = 1.6.0 = * A shipping method a group is shown is now reserved for that group: customers who match no group no longer see it. Previously a method set up for approved addresses stayed on the checkout for everyone, so free delivery meant for one company could be chosen by anybody. Customers are never left with no shipping method at all. = 1.4.6 = * Housekeeping: the plugin's source moved to a shorter address. Updates continue to arrive as before, and nothing needs doing. = 1.4.5 = * Fixed: the plugin could offer its own release as an update to a different plugin. Plugins that update from the same place share one check inside WordPress, and this one answered for all of them instead of only for itself. If another such plugin is installed, update it as well. * "Vis detaljer" next to the update notice now opens the plugin's own details, with the release notes as the changelog. It previously showed "Plugin not found", because WordPress was asking wordpress.org about a plugin that is not published there. = 1.4.4 = * A new version now shows up within about fifteen minutes instead of being hidden behind a six-hour cache. The plugin was holding on to its own answer for longer than WordPress waits before asking again, so a release could be published and the shop shown nothing. = 1.4.3 = * The plugin is now credited to Kristian Wind, with a link to where its source lives. It previously carried a placeholder name. = 1.4.2 = * The plugin now has an icon, so it no longer shows up as a generic grey plug under Dashboard → Updates. * "Check again" on the updates screen really does check again. It previously reused a cached answer for up to six hours, which made a brand new version look like it had not been published. = 1.4.1 = * The update check now builds the download address itself instead of using the one the repository reports. The repository was reporting a plain-HTTP address on a raw IP, which would have meant downloading plugin code over an unencrypted connection to an address that is free to change. Anyone on 1.4.0 gets this automatically with the next update. = 1.4.0 = * The plugin now updates itself. WordPress checks the plugin's own release feed and offers new versions in Plugins and Dashboard → Updates, so an update no longer means uploading a zip by hand. The per-plugin "Enable auto-updates" link works too. * Tested against WordPress 7.1 and WooCommerce 11.1, and against the next release of each, so an update to either is checked before it reaches a shop rather than after. * Nothing about the site is sent when it checks for updates. The request is an unauthenticated read of a public file, and the user agent is overridden because WordPress's default one carries the site's own address. = 1.3.1 = * Hardened loading: a class file that cannot be read is now recorded and reported in an admin notice instead of causing a fatal error. During a plugin upgrade WordPress replaces files one at a time, so a request landing mid-copy could previously take down wp-admin. * Admin tabs are only shown when their controller loaded, so an incomplete install costs a tab rather than the whole screen. = 1.3.0 = * Added an audit log: every change made through the REST API is recorded with user, IP, endpoint and time, along with rejected and rate limited requests. Viewable under WooCommerce → Email Discounts → Audit Log, and via GET /wp-json/wc-edm/v1/audit-log. * Added rate limiting on the REST API (default 60 reads and 20 writes per minute per user or IP), returning HTTP 429. Limits are filterable. * Entries are pruned automatically after 30 days (filterable). = 1.2.0 = * Added a free shipping toggle on email assignments — matching customers get all shipping methods at zero cost, works with every assignment type. * Coupon assignments now pick from the shop's existing WooCommerce coupons in a dropdown instead of a free-text field. * Database schema upgrades automatically after plugin updates (no re-activation needed). = 1.1.0 = * Added REST API (namespace wc-edm/v1) for remote management of groups, email assignments and shipping rules. All routes require an authenticated user with the manage_woocommerce capability (use an Application Password over HTTPS). = 1.0.0 = * Initial release: discount groups, email assignments (group/coupon/custom), shipping rules, dashboard.