kristianwindandClaude Opus 5
d1703dcc03
The check asked whether "defined( 'ABSPATH' )" appeared anywhere in the file. A comment containing those words therefore passed it. Measured with a planted file whose only mention was in a comment: 15 shipped PHP files examined, every one guarded Green over a file with no guard at all — one that runs for anyone who fetches it directly, outside WordPress and outside every capability check the code assumes has already happened. This is the check with the worst consequence of being hollow, and it was hollow in the one way a grep always can be. From the cache session by way of security: a check that must RECOGNISE its own code has one blind spot per recognition method, and one that reads what the source actually says has none of that kind. PHP's tokeniser cannot be fooled by a comment, because it is the thing that decides what a comment is. ci/check-abspath.php parses each shipped file and looks for a real defined() call on ABSPATH or WP_UNINSTALL_PLUGIN. Comments and doc blocks are tokens of their own and are simply never examined. The count and the floor stay, for the reason every check here has them. Verified through the container path with php hidden from `command -v`, since static.sh runs on a Gitea runner that has no php: identical output either way. A 31st self-test assertion plants the same fixture. It is grade 2 evidence — a planted instance of exactly the failure the check describes, rather than an arbitrary trigger that only proves the check can go red at all. Two things that assertion caught about itself on its first run: The check's success line now says "parsed" where it said "examined", and the existing assertion on the count was still matching the old word. It went red rather than quietly matching nothing, which is why the wording is asserted at all. And `static.sh | grep -q` reports STATIC.SH's exit status under `set -o pipefail`, not grep's — and static.sh is expected to fail in that fixture, so the assertion read "not found" however the check behaved. The mirror image of the `go test | grep` trap already in the playbook. Output is captured to a variable first now, with the reason inline. Swept the kit for text belonging to other plugins while here, after cache found a comment in its copy describing security's tree: no NLSEC_/NLCAC_ references, and every path named in ci/ and tests/ either exists here or is WordPress core. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
99 lines
3.1 KiB
PHP
99 lines
3.1 KiB
PHP
<?php
|
|
/**
|
|
* Verify that every shipped PHP file really guards against direct access.
|
|
*
|
|
* 🔴 Tokenised, not grepped, and that is the whole point of the file.
|
|
*
|
|
* The grep version asked whether "defined( 'ABSPATH' )" appeared ANYWHERE in
|
|
* the file. A comment saying the guard is handled elsewhere therefore passed,
|
|
* and so did a file with the words and no guard at all. Measured: a planted
|
|
* file whose only mention was in a comment produced
|
|
* "15 shipped PHP files examined, every one guarded" — green over a file that
|
|
* runs for anyone who fetches it directly, outside WordPress and outside every
|
|
* capability check the code assumes has already happened.
|
|
*
|
|
* A check that must RECOGNISE its own code has one blind spot per recognition
|
|
* method; one that reads what the source actually says has none of that
|
|
* particular kind. PHP's own tokeniser cannot be fooled by a comment, because
|
|
* it is the thing that decides what a comment is.
|
|
*/
|
|
|
|
$min = 0;
|
|
$files = array();
|
|
foreach ( array_slice( $argv, 1 ) as $arg ) {
|
|
if ( 0 === strpos( $arg, '--min=' ) ) {
|
|
$min = (int) substr( $arg, 6 );
|
|
continue;
|
|
}
|
|
$files[] = $arg;
|
|
}
|
|
|
|
$guards = array( 'ABSPATH', 'WP_UNINSTALL_PLUGIN' );
|
|
$problems = 0;
|
|
$checked = 0;
|
|
|
|
foreach ( $files as $path ) {
|
|
if ( ! is_readable( $path ) ) {
|
|
printf( "::error file=%s::Listed as shipped but not readable.\n", $path );
|
|
++$problems;
|
|
continue;
|
|
}
|
|
|
|
++$checked;
|
|
$tokens = token_get_all( file_get_contents( $path ) );
|
|
$count = count( $tokens );
|
|
$found = false;
|
|
|
|
for ( $i = 0; $i < $count; $i++ ) {
|
|
$token = $tokens[ $i ];
|
|
|
|
// Comments and doc blocks are tokens of their own, so they are simply
|
|
// never examined. That is the property the grep version lacked.
|
|
if ( ! is_array( $token ) || T_STRING !== $token[0] || 'defined' !== strtolower( $token[1] ) ) {
|
|
continue;
|
|
}
|
|
|
|
// defined ( 'ABSPATH' ) — whitespace anywhere, quotes either kind.
|
|
$j = $i + 1;
|
|
while ( $j < $count && is_array( $tokens[ $j ] ) && T_WHITESPACE === $tokens[ $j ][0] ) {
|
|
++$j;
|
|
}
|
|
if ( $j >= $count || '(' !== $tokens[ $j ] ) {
|
|
continue;
|
|
}
|
|
++$j;
|
|
while ( $j < $count && is_array( $tokens[ $j ] ) && T_WHITESPACE === $tokens[ $j ][0] ) {
|
|
++$j;
|
|
}
|
|
if ( $j < $count && is_array( $tokens[ $j ] ) && T_CONSTANT_ENCAPSED_STRING === $tokens[ $j ][0] ) {
|
|
if ( in_array( trim( $tokens[ $j ][1], "'\"" ), $guards, true ) ) {
|
|
$found = true;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( ! $found ) {
|
|
printf(
|
|
"::error file=%s,line=1::No guard against direct access. Add: if ( ! defined( 'ABSPATH' ) ) { exit; }\n",
|
|
$path
|
|
);
|
|
++$problems;
|
|
}
|
|
}
|
|
|
|
// The floor, for the same reason every other check in this kit has one: "every
|
|
// shipped file is guarded" is also what zero shipped files prints.
|
|
if ( $checked < $min ) {
|
|
fwrite( STDERR, sprintf( "Only %d shipped PHP file(s) were examined, expected at least %d. The file list is wrong, so this check proved nothing.\n", $checked, $min ) );
|
|
exit( 1 );
|
|
}
|
|
|
|
if ( $problems > 0 ) {
|
|
printf( "\n%d of %d shipped PHP files have no guard against direct access.\n", $problems, $checked );
|
|
exit( 1 );
|
|
}
|
|
|
|
printf( " %d shipped PHP files parsed, every one guards against direct access\n", $checked );
|
|
exit( 0 );
|