kristianwindandClaude Opus 5
eca2851d35
Three things this repository could not do: prove the plugin still works on a
WordPress or WooCommerce released after it, get a fix onto a shop without
someone uploading a zip, and do either of those for the next plugin without
starting over.
ci/ is the test harness. ci/site-test.sh builds a throwaway WordPress +
WooCommerce in containers at any versions you name — including `nightly` and
`beta` — installs exactly the files the release zip will contain, and runs
tests/smoke.php inside it with wp eval-file. Real cart, real coupons, real
WC_Shipping_Rate objects: a mocked cart keeps passing after WooCommerce has
changed underneath it, which is the one failure worth catching here. WP_DEBUG
is on and any notice logged from this plugin's directory fails the build,
because that is the shape an upgrade actually breaks in — nothing fails, a
notice appears, and two releases later it is a fatal.
compat.yml runs that weekly against today's releases, the next WordPress and
the next WooCommerce, the oldest PHP the header promises and the newest PHP.
When it is green it opens a PR bumping "Tested up to" and "WC tested up to" —
only when green, because WooCommerce shows that second value to the shop owner
as an untested-plugin banner, and that banner is what they read before deciding
whether to press update.
includes/class-updater.php is the distribution half. It hooks
update_plugins_{hostname} for the host in the new "Update URI" header and reads
the Gitea release API, so WordPress handles the notice, the download, the
"Enable auto-updates" link and wp plugin update with no further code. Update
URI earns its place twice: since 5.8 a plugin that declares one is never asked
about on wordpress.org, so a .org plugin sharing this slug cannot be pushed
onto a shop running this one. The check sends nothing about the site and
overrides WordPress's default user agent, which carries the site's own URL.
release.yml tags, tests, builds, publishes — then reads the feed back with no
credentials. A private repository and a release with no zip attached both leave
a page that looks perfect to anyone logged in and an update no shop is ever
offered.
Measured before committing, all green: WP 7.1 + WC 11.1 on PHP 8.3 and 7.4,
WP 7.2-alpha on 8.3, and the beta cell falling back to stable on 8.4. No
deprecations from this plugin on any of them.
Three guards are there because the bug they catch is invisible without them:
the annotated tag is re-fetched before its message is read (checkout turns it
into a lightweight tag pointing at the merge commit), the two workflow roots
are kept in sync (.gitea/workflows hides .github/workflows entirely), and every
file the code loads must be in the release zip — which caught class-updater.php
being referenced and uncommitted while every local test passed.
docs/REUSE.md is the port to the next plugin: copy ci/, rewrite five lines.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
26 lines
1.2 KiB
Markdown
26 lines
1.2 KiB
Markdown
# Why this directory exists, and the trap it carries
|
|
|
|
Gitea uses `.gitea/workflows` **if it exists**, and falls back to
|
|
`.github/workflows` only when it does not. It never merges them.
|
|
|
|
So adding one Gitea-only workflow here silently switches off CI — and therefore
|
|
auto-merge — for the whole repository on Gitea. There is no error and no run to
|
|
click on. It looks exactly like a runner that has not picked the job up, so you
|
|
wait, and waiting never fixes it.
|
|
|
|
**Every workflow that must run on Gitea has to be in this directory.**
|
|
`ci.yml` and `compat.yml` are kept byte-identical in both roots, and
|
|
`ci/workflows-in-sync.sh` fails if the two copies drift apart or if a workflow
|
|
appears in only one of them without a stated reason.
|
|
|
|
`release.yml` is the deliberate exception: a release workflow publishes to
|
|
whichever forge runs it, and the two copies publish to different places. The
|
|
Gitea one is the one that matters — that is where the update feed shops read
|
|
lives.
|
|
|
|
Two further rules learned the hard way:
|
|
|
|
- **No `concurrency:` block in a Gitea workflow.** It produces no run at all —
|
|
not a failed one, not a cancelled one. Same shape of trap, same symptom.
|
|
- If a Gitea workflow produces no run, **suspect the file, not the runner**.
|