kw/nolimit-discounts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #25 from kristianwind/smoke-rest-namespace
CI / Static checks (push) Successful in 40s
Details
CI / WordPress latest + WooCommerce latest on PHP 8.3 (push) Successful in 59s
Details

Browse Source 
Assert the REST namespace by name, not against its own constant
This commit is contained in:
Kristian Wind
2026-09-17 10:31:32 +02:00
committed by GitHub
parent 3f24b57579 9901efd8b2
commit d8b4afde07
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/smoke.php
+12
View File
@@ -211,6 +211,18 @@ $ours = array_filter(
); );
wc_edm_ok( 'the REST routes are registered', count( $ours ) > 0, 'namespace ' . WC_EDM_REST_API::REST_NAMESPACE ); wc_edm_ok( 'the REST routes are registered', count( $ours ) > 0, 'namespace ' . WC_EDM_REST_API::REST_NAMESPACE );
// The namespace spelled out, NOT compared to the constant it came from. The
// filter above derives what it looks for from REST_NAMESPACE, so it agrees
// with itself whatever that constant says: rename it and the routes are still
// "registered", while every caller that already integrated against
// wc-edm/v1 gets a 404 and nothing here goes red. This is the one string in
// the plugin that somebody else's code depends on by name.
wc_edm_is(
'and under the namespace callers already integrated against',
'wc-edm/v1',
WC_EDM_REST_API::REST_NAMESPACE
);
$request = new WP_REST_Request( 'GET', '/' . WC_EDM_REST_API::REST_NAMESPACE . '/groups' ); $request = new WP_REST_Request( 'GET', '/' . WC_EDM_REST_API::REST_NAMESPACE . '/groups' );
$response = rest_get_server()->dispatch( $request ); $response = rest_get_server()->dispatch( $request );
wc_edm_is( 'and they refuse an unauthenticated caller', 401, $response->get_status() ); wc_edm_is( 'and they refuse an unauthenticated caller', 401, $response->get_status() );