Credit the plugin to its actual author, and 1.4.3
The header went out as "Author: WEDSMP" with a Plugin URI of example.com. That is what wp-admin shows to whoever installs it, which is why it is worth a release of its own rather than waiting for the next change. Author is now Kristian Wind, with an Author URI pointing at where the source lives, and the readme credits kristianwind rather than wedsmp. ci/static.sh now fails on a placeholder in the header. It catches the generic markers — example.com, TODO, yourname, an unfilled <...> — and it would have caught the Plugin URI. It would NOT have caught "WEDSMP": a made-up vendor name is indistinguishable from a real one to any check, so an empty field is warned about and a wrong-but-plausible one cannot be. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
426015bb12
commit
056be0e917
+5
-2
@@ -1,10 +1,10 @@
|
|||||||
=== WooCommerce Email Discount Manager ===
|
=== WooCommerce Email Discount Manager ===
|
||||||
Contributors: wedsmp
|
Contributors: kristianwind
|
||||||
Tags: woocommerce, discount, email, shipping, coupon
|
Tags: woocommerce, discount, email, shipping, coupon
|
||||||
Requires at least: 5.8
|
Requires at least: 5.8
|
||||||
Tested up to: 7.1
|
Tested up to: 7.1
|
||||||
Requires PHP: 7.4
|
Requires PHP: 7.4
|
||||||
Stable tag: 1.4.2
|
Stable tag: 1.4.3
|
||||||
WC requires at least: 6.0
|
WC requires at least: 6.0
|
||||||
WC tested up to: 11.1.0
|
WC tested up to: 11.1.0
|
||||||
License: GPLv2 or later
|
License: GPLv2 or later
|
||||||
@@ -96,6 +96,9 @@ The most specific match wins: exact email, then domain, then partial match.
|
|||||||
|
|
||||||
== Changelog ==
|
== Changelog ==
|
||||||
|
|
||||||
|
= 1.4.3 =
|
||||||
|
* The plugin is now credited to Kristian Wind, with a link to where its source lives. It previously carried a placeholder name.
|
||||||
|
|
||||||
= 1.4.2 =
|
= 1.4.2 =
|
||||||
* The plugin now has an icon, so it no longer shows up as a generic grey plug under Dashboard → Updates.
|
* The plugin now has an icon, so it no longer shows up as a generic grey plug under Dashboard → Updates.
|
||||||
* "Check again" on the updates screen really does check again. It previously reused a cached answer for up to six hours, which made a brand new version look like it had not been published.
|
* "Check again" on the updates screen really does check again. It previously reused a cached answer for up to six hours, which made a brand new version look like it had not been published.
|
||||||
|
|||||||
@@ -141,6 +141,30 @@ for readme in readme.txt README.txt; do
|
|||||||
|| note_fail "$readme has 'Stable tag: $stable' but the plugin header says $version."
|
|| note_fail "$readme has 'Stable tag: $stable' but the plugin header says $version."
|
||||||
done
|
done
|
||||||
|
|
||||||
|
ci_step "no placeholders left in the plugin header"
|
||||||
|
# The header is the plugin's business card: wp-admin shows the author and the
|
||||||
|
# links to whoever installs it, so a placeholder there survives for as long as
|
||||||
|
# nobody happens to look at that screen. This plugin shipped with
|
||||||
|
# "https://example.com/" as its Plugin URI for several releases.
|
||||||
|
#
|
||||||
|
# It catches the generic markers only. A made-up vendor name — this one went
|
||||||
|
# out as "WEDSMP" — looks exactly like a real one to any check, so an empty
|
||||||
|
# field is warned about but a wrong-but-plausible value cannot be.
|
||||||
|
before=$fails
|
||||||
|
for field in 'Plugin Name' 'Description' 'Author' 'Author URI' 'Plugin URI'; do
|
||||||
|
value=$(ci_plugin_header "$field")
|
||||||
|
if [ -z "$value" ]; then
|
||||||
|
echo "::warning::The plugin header has no '$field:'."
|
||||||
|
continue
|
||||||
|
fi
|
||||||
|
case "$value" in
|
||||||
|
*example.com*|*example.org*|*yourname*|*YOUR_*|*TODO*|*FIXME*|*changeme*|*'<'*'>'*)
|
||||||
|
note_fail "$field is still a placeholder: $value"
|
||||||
|
;;
|
||||||
|
esac
|
||||||
|
done
|
||||||
|
[ "$fails" = "$before" ] && echo " name, description, author and links are all filled in"
|
||||||
|
|
||||||
ci_step "the compatibility headers still tell the truth"
|
ci_step "the compatibility headers still tell the truth"
|
||||||
# Advisory, never fatal. WordPress ships a new version whether or not anything
|
# Advisory, never fatal. WordPress ships a new version whether or not anything
|
||||||
# here is wrong, and a build that goes red on release day for a header nobody
|
# here is wrong, and a build that goes red on release day for a header nobody
|
||||||
|
|||||||
@@ -4,8 +4,9 @@
|
|||||||
* Plugin URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager
|
* Plugin URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager
|
||||||
* Update URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager
|
* Update URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager
|
||||||
* Description: Apply discounts and show/hide shipping methods based on the customer's email address (full address, domain or partial match).
|
* Description: Apply discounts and show/hide shipping methods based on the customer's email address (full address, domain or partial match).
|
||||||
* Version: 1.4.2
|
* Version: 1.4.3
|
||||||
* Author: WEDSMP
|
* Author: Kristian Wind
|
||||||
|
* Author URI: https://gitea.nolimit.dk/kw
|
||||||
* License: GPL-2.0-or-later
|
* License: GPL-2.0-or-later
|
||||||
* Text Domain: wc-email-discount
|
* Text Domain: wc-email-discount
|
||||||
* Requires at least: 5.8
|
* Requires at least: 5.8
|
||||||
@@ -27,7 +28,7 @@ if ( ! defined( 'ABSPATH' ) ) {
|
|||||||
exit;
|
exit;
|
||||||
}
|
}
|
||||||
|
|
||||||
define( 'WC_EDM_VERSION', '1.4.2' );
|
define( 'WC_EDM_VERSION', '1.4.3' );
|
||||||
define( 'WC_EDM_PLUGIN_FILE', __FILE__ );
|
define( 'WC_EDM_PLUGIN_FILE', __FILE__ );
|
||||||
define( 'WC_EDM_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
|
define( 'WC_EDM_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
|
||||||
define( 'WC_EDM_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
|
define( 'WC_EDM_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
|
||||||
|
|||||||
Reference in New Issue
Block a user