diff --git a/README.txt b/README.txt index 57738dd..9fe0b20 100644 --- a/README.txt +++ b/README.txt @@ -1,10 +1,10 @@ === WooCommerce Email Discount Manager === -Contributors: wedsmp +Contributors: kristianwind Tags: woocommerce, discount, email, shipping, coupon Requires at least: 5.8 Tested up to: 7.1 Requires PHP: 7.4 -Stable tag: 1.4.2 +Stable tag: 1.4.3 WC requires at least: 6.0 WC tested up to: 11.1.0 License: GPLv2 or later @@ -96,6 +96,9 @@ The most specific match wins: exact email, then domain, then partial match. == Changelog == += 1.4.3 = +* The plugin is now credited to Kristian Wind, with a link to where its source lives. It previously carried a placeholder name. + = 1.4.2 = * The plugin now has an icon, so it no longer shows up as a generic grey plug under Dashboard → Updates. * "Check again" on the updates screen really does check again. It previously reused a cached answer for up to six hours, which made a brand new version look like it had not been published. diff --git a/ci/static.sh b/ci/static.sh index 5015d3a..bd001ef 100755 --- a/ci/static.sh +++ b/ci/static.sh @@ -141,6 +141,30 @@ for readme in readme.txt README.txt; do || note_fail "$readme has 'Stable tag: $stable' but the plugin header says $version." done +ci_step "no placeholders left in the plugin header" +# The header is the plugin's business card: wp-admin shows the author and the +# links to whoever installs it, so a placeholder there survives for as long as +# nobody happens to look at that screen. This plugin shipped with +# "https://example.com/" as its Plugin URI for several releases. +# +# It catches the generic markers only. A made-up vendor name — this one went +# out as "WEDSMP" — looks exactly like a real one to any check, so an empty +# field is warned about but a wrong-but-plausible value cannot be. +before=$fails +for field in 'Plugin Name' 'Description' 'Author' 'Author URI' 'Plugin URI'; do + value=$(ci_plugin_header "$field") + if [ -z "$value" ]; then + echo "::warning::The plugin header has no '$field:'." + continue + fi + case "$value" in + *example.com*|*example.org*|*yourname*|*YOUR_*|*TODO*|*FIXME*|*changeme*|*'<'*'>'*) + note_fail "$field is still a placeholder: $value" + ;; + esac +done +[ "$fails" = "$before" ] && echo " name, description, author and links are all filled in" + ci_step "the compatibility headers still tell the truth" # Advisory, never fatal. WordPress ships a new version whether or not anything # here is wrong, and a build that goes red on release day for a header nobody diff --git a/woocommerce-email-discount-manager.php b/woocommerce-email-discount-manager.php index ef4e0b8..e7c7c82 100644 --- a/woocommerce-email-discount-manager.php +++ b/woocommerce-email-discount-manager.php @@ -4,8 +4,9 @@ * Plugin URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager * Update URI: https://gitea.nolimit.dk/kw/woocommerce-email-discount-manager * Description: Apply discounts and show/hide shipping methods based on the customer's email address (full address, domain or partial match). - * Version: 1.4.2 - * Author: WEDSMP + * Version: 1.4.3 + * Author: Kristian Wind + * Author URI: https://gitea.nolimit.dk/kw * License: GPL-2.0-or-later * Text Domain: wc-email-discount * Requires at least: 5.8 @@ -27,7 +28,7 @@ if ( ! defined( 'ABSPATH' ) ) { exit; } -define( 'WC_EDM_VERSION', '1.4.2' ); +define( 'WC_EDM_VERSION', '1.4.3' ); define( 'WC_EDM_PLUGIN_FILE', __FILE__ ); define( 'WC_EDM_PLUGIN_DIR', plugin_dir_path( __FILE__ ) ); define( 'WC_EDM_PLUGIN_URL', plugin_dir_url( __FILE__ ) );